fix(tools): reject non-positive topic receive/image/TF timeouts - #827
Closed
Bartok9 wants to merge 1 commit into
Closed
fix(tools): reject non-positive topic receive/image/TF timeouts#827Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Add require_positive_timeout helper and use it in ReceiveROS2MessageTool, GetROS2ImageTool, and GetROS2TransformTool so agent-provided timeouts cannot be zero, negative, boolean, or NaN. Offline unit tests cover the helper. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Member
|
Took this in #872, though as gt=0 on the timeout_sec fields in the args_schema rather than a helper in _run. Pydantic rejects the call before it reaches us and the constraint lands in the tool schema the model sees. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent-supplied
timeout_secon receive/image/TF tools can be 0/negative/bool/NaN.Adds
require_positive_timeoutand wires it into ReceiveROS2MessageTool, GetROS2ImageTool, GetROS2TransformTool.Testing
Claim: bartok
Operator: bartok
Campaign: aerial-drone